warn pre-start() errors

[perl/plp/.git] / lib / PLP / Backend / CGI.pm

diff --git a/lib/PLP/Backend/CGI.pm b/lib/PLP/Backend/CGI.pm
index 0005762dd5fe5d66cfedbfb0cc702cc4cfcc7b2b..3acf63d9de9269db611366c5d961860699248a81 100644 (file)
--- a/lib/PLP/Backend/CGI.pm
+++ b/lib/PLP/Backend/CGI.pm
@@ -1,8 +1,9 @@
 package PLP::Backend::CGI;
 
 use strict;
+use warnings;
 
-our $VERSION = '1.02';
+our $VERSION = '1.03';
 
 use PLP;
 
@@ -16,17 +17,17 @@ sub init {
                # Run backwards through PATH_TRANSLATED to find target filename,
                # then get file (relative) by stripping PATH_INFO.
                my ($path, $rel) = (delete $ENV{PATH_TRANSLATED}, delete $ENV{PATH_INFO});
-               my $path_info;
+               my $path_info = '';
                while (not -f $path) {
                        if (not $path =~ s/(\/+[^\/]*)$//) {
-                               printf STDERR "PLP: Not found: $path$path_info ($ENV{REQUEST_URI})\n";
+                               warn "PLP: Not found: $path$path_info ($ENV{REQUEST_URI})\n";
                                PLP::error(undef, 404);
                                return;
                        }
                        # move last path element onto PATH_INFO
                        $path_info = $1 . $path_info;
                }
-               if (defined $path_info) {
+               if ($path_info ne '') {
                        $rel =~ s/\Q$path_info\E$//;
                        $ENV{PATH_INFO} = $path_info;
                }
@@ -34,7 +35,7 @@ sub init {
                $ENV{SCRIPT_NAME} = $rel;
        }
        elsif (not -f $ENV{SCRIPT_FILENAME}) {
-               print STDERR "PLP: Not found: $ENV{SCRIPT_FILENAME} ($ENV{REQUEST_URI})\n";
+               warn "PLP: Not found: $ENV{SCRIPT_FILENAME} ($ENV{REQUEST_URI})\n";
                PLP::error(undef, 404);
                return;
        }
@@ -42,7 +43,7 @@ sub init {
        $ENV{"PLP_$_"} = $ENV{"SCRIPT_$_"} for qw/NAME FILENAME/;
 
        if (not -r $ENV{PLP_FILENAME}) {
-               print STDERR "PLP: Can't read: $ENV{PLP_FILENAME} ($ENV{REQUEST_URI})\n";
+               warn "PLP: Can't read: $ENV{PLP_FILENAME} ($ENV{REQUEST_URI})\n";
                PLP::error(undef, 403);
                return;
        }
@@ -93,12 +94,12 @@ Or install the C<plp.cgi> included with PLP.
 
 =head2 Lighttpd
 
-Usually in F</etc/lighttpd/lighttpd.conf>:
-enable I<mod_cgi> (add/outcomment in server.modules), and add:
+Add this to your configuration file (usually F</etc/lighttpd/lighttpd.conf>):
 
-    cgi.assign = (
-        ".plp" => "/foo/bar/plp.cgi",
-    )
+    server.modules += ("mod_cgi")
+    cgi.assign += (".plp" => "/foo/bar/plp.cgi")
+    server.indexfiles += ("index.plp")
+    static-file.exclude-extensions += (".plp")
 
 =head2 Apache