login/pass: error messages below page title

[minimedit.git] / thumb / index.php

diff --git a/thumb/index.php b/thumb/index.php
index aadbf4f91eb664d1abc0109ca477d5e4aa71559c..9232b3332be5de1c33370705b4ea41e273b427d3 100644 (file)
--- a/thumb/index.php
+++ b/thumb/index.php
@@ -1,19 +1,28 @@
 <?php
-ob_clean();
-
-list ($size, $imgpath) = explode('/', ltrim($Args, '/'), 2);
+if ($Page->api) return;
+$imgpath = ltrim($Page->path, '/');
+if (!preg_match('{^[0-9x]+/}', $imgpath)) {
+       return;
+}
+list ($size, $imgpath) = explode('/', $imgpath, 2);
 $imgpath = preg_replace('{^(?=[0-9]+/)}', 'data/', $imgpath, 1);
+$ext = ''; # explicit file type request
 
-if (!file_exists($imgpath)) {
+if (preg_match('/(.*)(\.jpg)$/', $imgpath, $imgpart) and file_exists($imgpart[1])) {
+       # source file without requested thumb extension
+       list (, $imgpath, $ext) = $imgpart;
+}
+elseif (!file_exists($imgpath)) {
        http_response_code(404);
        $imgpath = '404.png';
        if (!file_exists($imgpath)) {
                exit;
        }
 }
+$target = "thumb/$size/$imgpath$ext";
 
 try {
-       $target = mkthumb($imgpath, $size);
+       mkthumb($imgpath, $size, $target);
 }
 catch (Throwable $e) {
        http_response_code($e->getCode() ?: 500);
@@ -28,12 +37,13 @@ catch (Throwable $e) {
        exit;
 }
 
-header('Cache-Control: max-age=2628000, immutable');
-header('Content-type: '.mime_content_type($target));
+header('Cache-Control: max-age=2628000');
+header('Content-Type: '.mime_content_type($target));
+header('Content-Length: '.filesize($target));
 readfile($target);
 exit;
 
-function mkthumb($source, $size)
+function mkthumb($source, $size, $target)
 {
        if (strpos($size, 'x') !== FALSE) {
                list ($width, $height) = explode('x', $size);
@@ -47,7 +57,6 @@ function mkthumb($source, $size)
        if (empty($width)) {
                $width = $height * 4;
        }
-       $target = "thumb/$size/$source";
 
        if (isset($_GET['backend'])) {
                $backend = $_GET['backend'];
@@ -89,10 +98,15 @@ function mkthumb_exec($source, $target, $width, $height)
        }
        $cmd = implode(' ', array_map('escapeshellarg', [
                'convert',
+               '-delete', '1--1', # static
                '-trim',
-               '-background', 'white', '-layers', 'flatten',
-               '-resize', "${width}x${height}",
-               '-quality', '90%',
+               '-background', 'white', '-layers', 'flatten', # opaque
+               '-auto-orient', # apply exif rotation
+               '-interlace', 'plane', # progressive
+               '-strip', '-taint', # omit metadata
+               '-sampling-factor', '4:2:0', '-colorspace', 'sRGB', # half chroma
+               '-resize', "${width}x${height}>",
+               '-quality', '85%',
                $source, "jpg:$target"
        ]));
        $return = shell_exec("$cmd 2>&1");