login/edit: silence alter error for custom input

[minimedit.git] / login / edit.php

diff --git a/login/edit.php b/login/edit.php
index 759eba5f10e61a359cb61027d1ae1fcbb7696487..31d4d20875de16661d71cd517701715a5a7baef2 100644 (file)
--- a/login/edit.php
+++ b/login/edit.php
@@ -59,26 +59,24 @@ if (file_exists($tagdir)) {
        foreach (glob("$tagdir/*") as $tag) {
                $tagname = pathinfo($tag, PATHINFO_BASENAME);
                $target = "$tag/{$user['name']}";
-               $tags[$tagname] = file_exists($tagname);
+               $val = file_exists($target);
+               $tags[$tagname] = ['value' => $val];
+               if (empty($User['admin'])) {
+                       continue;  # forbidden
+               }
+               if (!is_writable($tag)) {
+                       continue;  # locked tag directory
+               }
+               if ($val and !is_writable($target)) {
+                       continue;  # existing file locked
+               }
+               $tags[$tagname]['target'] = $target;
        }
 
        if ($tags) {
-               $options = '';
-               foreach ($tags as $tag => $val) {
-                       $options .= sprintf(
-                               "\n\t\t" .
-                               '<input type="hidden" name="tags[%1$s]" value="" />' .
-                               '<input type="checkbox" name="tags[%s]" value="1"%s%s /> %s',
-                               $tag,
-                               $val ? ' checked' : '',
-                               ' readonly',
-                               ucfirst($tag)
-                       );
-               }
-
                $cols['tags'] = [
                        'label' => 'groepen',
-                       'input' => $options,
+                       'values' => $tags,
                ];
        }
 }
@@ -107,12 +105,42 @@ if ($_POST) {
                if (!isset($cols[$col])) {
                        continue; # unknown
                }
+               if (isset($cols[$col]['values'])) {
+                       $optwarn = [];
+                       foreach ($val as $optcol => $optval) {
+                               $option = &$cols[$col]['values'][$optcol];
+                               if (!isset($option['target'])) {
+                                       $optok = FALSE;  # forbidden
+                               }
+                               if ($option['value'] === !empty($optval)) {
+                                       continue;  # unaltered
+                               }
+                               elseif (empty($optval)) {
+                                       $optok = @unlink($option['target']);
+                               }
+                               else {
+                                       # link option target to current user dir
+                                       $optok = @symlink("../../{$user['name']}", $option['target']);
+                               }
+                               $option['value'] = $optval;  # update form value
+                               if (!$optok) {
+                                       $optwarn[$optcol] = TRUE;
+                               }
+                       }
+                       if ($optwarn) {
+                               $colwarn[$col] = "Wijziging niet opgeslagen voor "
+                                       . implode(', ', array_keys($optwarn));
+                       }
+                       continue;
+               }
                if (isset($cols[$col]['value']) and $cols[$col]['value'] === $val) {
                        continue; # unaltered
                }
                $cols[$col]['value'] = $val;  # update form value
                if (empty($cols[$col]['target'])) {
-                       $colwarn[$col] = "Kan niet worden aangepast.";
+                       if (empty($cols[$col]['input'])) {
+                               $colwarn[$col] = "Kan niet worden aangepast.";
+                       }
                        continue;
                }
                if (file_put_contents($cols[$col]['target'], $val) === FALSE) {
@@ -186,6 +214,20 @@ foreach ($cols as $col => &$colconf) {
        if (isset($colconf['input'])) {
                print $colconf['input'];
        }
+       elseif (isset($colconf['values'])) {
+               foreach ($colconf['values'] as $tag => $val) {
+                       printf(
+                               "\n\t\t" .
+                               '<input type="hidden" name="%1$s" value="" />' .
+                               '<input type="checkbox" name="%s" value="1" id="%s"%s%s />' .
+                               '<label for="%2$s"> %s</label>',
+                               "tags[$tag]", "tag-$tag",
+                               $val['value'] ? ' checked' : '',
+                               isset($val['target']) ? '' : ' readonly',
+                               ucfirst($tag)
+                       );
+               }
+       }
        else {
                $attrs = [
                        'type'        => @$colconf['type'] ?: 'text',
@@ -212,6 +254,7 @@ foreach ($cols as $col => &$colconf) {
                }
                print ' />';
        }
+
        if (!empty($colconf['explain'])) {
                printf(' <span>(%s)</span>', $colconf['explain']);
        }