login/edit: silence code warning on missing values

[minimedit.git] / login / edit.php

diff --git a/login/edit.php b/login/edit.php
index 49b8ed8c43e821092694b4c9953cbb154f507595..9b339a22dedf1cd8121bbda10777931190137194 100644 (file)
--- a/login/edit.php
+++ b/login/edit.php
@@ -17,7 +17,15 @@ and !empty($Place['user']) and $Place['user'] !== $User['name']) {
 require_once('edit.inc.php');
 
 foreach ($cols as $col => &$colconf) {
-       $colconf['visible'] = TRUE;
+       if (isset($colconf['visible'])) {
+               if ($colconf['visible'] == 'admin' and empty($User['admin'])) {
+                       $colconf['visible'] = FALSE;
+                       continue;
+               }
+       }
+       else {
+               $colconf['visible'] = TRUE;
+       }
 
        if (!isset($colconf['filename'])) {
                continue;  # exceptional storage
@@ -34,9 +42,6 @@ foreach ($cols as $col => &$colconf) {
                        $target = "$tag/{$user['name']}";
                        $val = file_exists($target);
                        $tags[$tagname] = ['value' => $val];
-                       if (empty($User['admin'])) {
-                               continue;  # forbidden
-                       }
                        if (!is_writable($tag)) {
                                continue;  # locked tag directory
                        }
@@ -200,7 +205,7 @@ foreach ($cols as $col => &$colconf) {
        else {
                if (isset($cols[$col]['filter'])) {
                        list ($targetstr, $inputstr) = $cols[$col]['filter'];
-                       $colconf['value'] = str_replace($targetstr, $inputstr, $colconf['value']);
+                       $colconf['value'] = str_replace($targetstr, $inputstr, @$colconf['value']);
                }
 
                $attrs = [