From: Mischa POSLAWSKY <perl@shiar.org>
Date: Sat, 31 Mar 2007 01:43:13 +0000 (+0200)
Subject: minor code cleanups and clarifications
X-Git-Tag: 3.19~1
X-Git-Url: http://git.shiar.net/perl/plp/.git/commitdiff_plain/60df7c89bf8eb6f20a41600a6186a990561eb77a

minor code cleanups and clarifications
---

diff --git a/PLP/Functions.pm b/PLP/Functions.pm
index b4891ee..fe1f39c 100644
--- a/PLP/Functions.pm
+++ b/PLP/Functions.pm
@@ -4,8 +4,8 @@ use base 'Exporter';
 use Fcntl qw(:flock);
 use strict;
 
-our @EXPORT = qw/Entity DecodeURI EncodeURI include PLP_END
-                 AddCookie ReadFile WriteFile AutoURL Counter Include exit/;
+our @EXPORT = qw/Entity DecodeURI EncodeURI Include include PLP_END
+                 AddCookie ReadFile WriteFile AutoURL Counter exit/;
 
 sub Include ($) {
 	no strict;
@@ -37,7 +37,7 @@ sub Entity (@) {
 	for (@$ref) {
 		eval {
 			s/&/&amp;/g;
-			s/\"/&quot;/g;
+			s/"/&quot;/g;
 			s/</&lt;/g;
 			s/>/&gt;/g;
 			s/\n/<br>\n/g;
@@ -144,7 +144,7 @@ sub AutoURL ($) {
 		$$ref =~ s/>\cC>/&gt;/g;
 		$$ref =~ s/<\cC</&lt;/g;
 	};
-	if ($@){ return defined wantarray ? @_ : undef }
+	if ($@){ return defined wantarray ? @_ : undef }  # return original on error
 	return defined wantarray ? $$ref : undef;
 }
 
@@ -206,7 +206,7 @@ You should use this function instead of Perl's built-in C<END> blocks, because t
 
 =item Entity LIST
 
-Replaces HTML syntax characters by HTML entities, so they can be displayed literally. You should always use this on user input (or database output), to avoid cross-site-scripting vurnerabilities. This function does not do everything the L<HTML::Entity> does.
+Replaces HTML syntax characters by HTML entities, so they can be displayed literally. You should always use this when displaying user input (or database output), to avoid cross-site-scripting vurnerabilities.
 
 In void context, B<changes> the values of the given variables. In other contexts, returns the changed versions.