From 0f46a9fa54c9ecca0f0c3180b51f7c3079d048a8 Mon Sep 17 00:00:00 2001
From: Mischa POSLAWSKY <perl@shiar.org>
Date: Thu, 12 Nov 2009 20:50:43 +0100
Subject: [PATCH] XXX: ranges returned as scalars, not arrays

---
 lib/List/Index.pm | 10 +++++-----
 t/10-ranges.t     | 23 +++++++++--------------
 t/20-links.t      |  1 +
 3 files changed, 15 insertions(+), 19 deletions(-)

diff --git a/lib/List/Index.pm b/lib/List/Index.pm
index 57027fa..ea7b433 100644
--- a/lib/List/Index.pm
+++ b/lib/List/Index.pm
@@ -62,14 +62,14 @@ sub ranges {
 	}
 
 	use List::MoreUtils 'uniq';
-	@links = map { [$_] } uniq @links;
+	@links = uniq @links;
 	for my $i (0 .. $#links - 1) {
-		my ($link, $lastchar) = $links[$i + 1]->[0] =~ /(.*)(.)/;
+		my ($link, $lastchar) = $links[$i + 1] =~ /(.*)(.)/;
 		$link .= $lastchar le 'a' ? '.' : chr( ord($lastchar) - 1 );
-		next if $link eq $links[$i]->[0] and $i;
-		$links[$i]->[1] = $link;
+		next if $link eq $links[$i] and $i;
+		$links[$i] .= '-'.$link;
 	}
-	$links[-1]->[1] = '';
+	$links[-1] .= '-';
 
 	return \@links;
 }
diff --git a/t/10-ranges.t b/t/10-ranges.t
index 3667034..aa87a87 100644
--- a/t/10-ranges.t
+++ b/t/10-ranges.t
@@ -13,24 +13,20 @@ ok(eval { List::Index->VERSION(1) }, 'version 1.00 compatibility');
 my @uniform = 'a'..'z';
 ok(my $index = List::Index->new(\@uniform), 'object (single-char values)');
 is_deeply(\@uniform, ['a'..'z'], 'original data unaltered');
-is_deeply($index->ranges, [['','']], 'single page');
-is_deeply($index->ranges({pages => 3}), [map { [split /-/, $_, 3] } qw(
-	-h i-q r-
-)], 'given pages');
-is_deeply($index->ranges({pagesize => @uniform / 2.1}), [map { [split /-/, $_, 2] } qw(
+is_deeply($index->ranges, ['-'], 'single page');
+is_deeply($index->ranges({pages => 3}), [qw(-h i-q r-)], 'given pages');
+is_deeply($index->ranges({pagesize => @uniform / 2.1}), [qw(
 	-h i-q r-
 )], 'equivalent pagesize');
 }
 
 {
 ok(my $index = List::Index->new(['aa'..'zz', 1..193]), 'non-alphabetic values (uniform)');
-is_deeply($index->ranges, [map { [split /-/, $_, 2] } qw(
+is_deeply($index->ranges, [qw(
 	-. .
 	a-b c-dr ds-fn fo-hk hl-jg jh-k l-m n-o p-qr qs-sn so-uk ul-wg wh-x y-
 )], 'default ranges');
-is_deeply($index->ranges({pagesize => 300}), [map { [split /-/, $_, 2] } qw(
-	-c d-o p-
-)], 'large pagesize');
+is_deeply($index->ranges({pagesize => 300}), [qw(-c d-o p-)], 'large pagesize');
 }
 
 {
@@ -38,18 +34,17 @@ ok(my $index = List::Index->new([qw(
 	baa1 baa2  baa3 baaa  bbc cbc  daaa ea  eaaa zed
 )]), 'variable length values');
 is_deeply($index->ranges({pagesize => 2, context => 0}), [
-	map { [split /-/, $_, 2] } qw(-baa. baa.-bbb bbc-daa. daaa-eaa. eaaa-)
+	qw(-baa. baa.-bbb bbc-daa. daaa-eaa. eaaa-)
 ], 'no context');
 is_deeply($index->ranges({pagesize => 2}), [
-	map { [split /-/, $_, 2] } qw(-a b c d-ea. eaa-)
+	qw(-a b c d-ea. eaa-)
 ], 'default context');  # context should be 1
 is_deeply($index->ranges({pagesize => 2, context => 2}), [
-	map { [split /-/, $_, 2] } qw(-a b-c d e-)
+	qw(-a b-c d e-)
 ], 'overlap');  # first item equals second due to large context
 is_deeply($index->ranges({pagesize => 2, length => 1}), [
-	map { [split /-/, $_, 2] } qw(-a b-c d e-)
+	qw(-a b-c d e-)
 ], 'single char');
 
 #pp($index->ranges({pagesize => 2, context => 2, length => 1}));
 }
-
diff --git a/t/20-links.t b/t/20-links.t
index d9ab338..b1879e3 100644
--- a/t/20-links.t
+++ b/t/20-links.t
@@ -45,3 +45,4 @@ for my $in (
 ) {
 	is(eval { rangematch($in) }, undef, (length $in ? $in : q{''}) . ' failure');
 }
+
-- 
2.30.0