XXX: omit duplicates (overlaps)

diff --git a/lib/List/Index.pm b/lib/List/Index.pm
index bf4e04db592dabcf488ab9a2dfd5386bbd3a4668..57027fa685656c8608c2bcd0a54a21fb93f264f9 100644 (file)
--- a/lib/List/Index.pm
+++ b/lib/List/Index.pm
@@ -24,7 +24,7 @@ sub ranges {
 
        $pagesize = @$self / $pages;
        my $offset = $pagesize;
-       my @links = (['']);
+       my @links = ('');
        while ($offset < @$self) {
                my $link = substr $self->[$offset], 0, $length;
                if ($context) {
@@ -57,10 +57,12 @@ sub ranges {
                        }
                }
 
-               push @links, [$link];
+               push @links, $link;
                $offset += $pagesize;
        }
 
+       use List::MoreUtils 'uniq';
+       @links = map { [$_] } uniq @links;
        for my $i (0 .. $#links - 1) {
                my ($link, $lastchar) = $links[$i + 1]->[0] =~ /(.*)(.)/;
                $link .= $lastchar le 'a' ? '.' : chr( ord($lastchar) - 1 );

diff --git a/t/10-ranges.t b/t/10-ranges.t
index 66edf7607ccc1b0922c376fb8d6b2fe8fb9ae817..3667034f8cfc13e666d28197a414885e8c6a51a3 100644 (file)
--- a/t/10-ranges.t
+++ b/t/10-ranges.t
@@ -25,7 +25,7 @@ is_deeply($index->ranges({pagesize => @uniform / 2.1}), [map { [split /-/, $_, 2
 {
 ok(my $index = List::Index->new(['aa'..'zz', 1..193]), 'non-alphabetic values (uniform)');
 is_deeply($index->ranges, [map { [split /-/, $_, 2] } qw(
-       -. . . .
+       -. .
        a-b c-dr ds-fn fo-hk hl-jg jh-k l-m n-o p-qr qs-sn so-uk ul-wg wh-x y-
 )], 'default ranges');
 is_deeply($index->ranges({pagesize => 300}), [map { [split /-/, $_, 2] } qw(
@@ -44,10 +44,10 @@ is_deeply($index->ranges({pagesize => 2}), [
        map { [split /-/, $_, 2] } qw(-a b c d-ea. eaa-)
 ], 'default context');  # context should be 1
 is_deeply($index->ranges({pagesize => 2, context => 2}), [
-       map { [split /-/, $_, 2] } qw(-a b-c d-c d e-)
+       map { [split /-/, $_, 2] } qw(-a b-c d e-)
 ], 'overlap');  # first item equals second due to large context
 is_deeply($index->ranges({pagesize => 2, length => 1}), [
-       map { [split /-/, $_, 2] } qw(-a b-a b-c d e-)
+       map { [split /-/, $_, 2] } qw(-a b-c d e-)
 ], 'single char');
 
 #pp($index->ranges({pagesize => 2, context => 2, length => 1}));