From bb5bd81e03c47ff9cc779c5109bd6e042219a1f8 Mon Sep 17 00:00:00 2001 From: Mischa Poslawsky Date: Thu, 31 Jul 2008 12:48:31 +0200 Subject: [PATCH] input method should be named text() Thinko: while it does create an input tag, it's specifically for text input elements. Was already documented as text(). --- lib/HTML/Form/Simple.pm | 2 +- t/html.t | 30 +++++++++++++++--------------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/lib/HTML/Form/Simple.pm b/lib/HTML/Form/Simple.pm index 730c41b..3a58c79 100644 --- a/lib/HTML/Form/Simple.pm +++ b/lib/HTML/Form/Simple.pm @@ -88,7 +88,7 @@ sub hidden { return $self->tag(input => $attr); } -sub input { +sub text { my $self = shift; my ($name, $value, $attr) = $self->_attr(2, @_); diff --git a/t/html.t b/t/html.t index a9ee150..2fea804 100644 --- a/t/html.t +++ b/t/html.t @@ -118,43 +118,43 @@ is( # input is( - $form->input, + $form->text, '', 'empty input' ); is( - $form->input(undef, undef, undef), + $form->text(undef, undef, undef), '', 'explicit empty input' ); is( - $form->input('test'), + $form->text('test'), '', 'input with name' ); is( - $form->input(undef, 'test'), + $form->text(undef, 'test'), '', 'input with value' ); is( - $form->input(undef, {value => 'test'}), + $form->text(undef, {value => 'test'}), '', 'input with attribute value' ); is( - $form->input({name => 'test', value => ''}), + $form->text({name => 'test', value => ''}), '', 'input with only attributes' ); is( - $form->input('', '', { + $form->text('', '', { disabled => 0, something => undef, class => undef, @@ -167,31 +167,31 @@ is( ); is( - $form->input(undef, undef, {name => '0', value => '0'}), + $form->text(undef, undef, {name => '0', value => '0'}), '', 'input overrides' ); is( - $form->input('name', {id => ''}), + $form->text('name', {id => ''}), '', 'input with id override' ); is( - $form->input('<">', '<">', {id => '>"<'}), + $form->text('<">', '<">', {id => '>"<'}), '', 'input quoting' ); is( - $form->input(undef, {disabled => 'something'}), + $form->text(undef, {disabled => 'something'}), '', 'disabled input' ); is( - $form->input({type => 'password'}), + $form->text({type => 'password'}), '', 'password' ); @@ -199,19 +199,19 @@ is( # textarea is( - $form->input({rows => 0}), + $form->text({rows => 0}), '', 'minimal textarea' ); is( - $form->input(foo => 'bar', {cols => 42, rows => 1, disabled => 1}), + $form->text(foo => 'bar', {cols => 42, rows => 1, disabled => 1}), '', 'textarea' ); is( - $form->input(undef, qq{&bl'a"\n .}, {cols => undef, rows => '<">'}), + $form->text(undef, qq{&bl'a"\n .}, {cols => undef, rows => '<">'}), qq{}, 'textarea quoting' ); -- 2.30.0