From: Mischa Poslawsky <mischa@mediadesign.nl>
Date: Fri, 25 Jul 2008 23:10:17 +0000 (+0200)
Subject: XXX: hidden options
X-Git-Url: http://git.shiar.net/perl/html-form-simple.git/commitdiff_plain/80de26e2b6b53f54ffb5232472e56c3225a101e1

XXX: hidden options
---

diff --git a/lib/HTML/Form/Simple.pm b/lib/HTML/Form/Simple.pm
index 4eddc98..66958c3 100644
--- a/lib/HTML/Form/Simple.pm
+++ b/lib/HTML/Form/Simple.pm
@@ -71,8 +71,9 @@ sub hidden {
 	my $self = shift;
 	my ($name, $value, $attr) = $self->_attr(2, @_);
 
-	$attr = {type => 'hidden', name => $name, value => $value};
-	#TODO: $attr
+	$attr->{name } = $name  if defined $name;
+	$attr->{value} = $value if defined $value;
+	$attr->{type} = 'hidden' unless defined $attr->{type};
 
 	return $self->tag(input => $attr);
 }
diff --git a/t/html.t b/t/html.t
index c646cdb..e5abb9a 100644
--- a/t/html.t
+++ b/t/html.t
@@ -5,7 +5,7 @@ use warnings;
 
 use Test::More;
 
-plan tests => 50;
+plan tests => 51;
 
 use_ok('HTML::Form::Simple');
 
@@ -52,7 +52,11 @@ is(
 	'hidden'
 );
 
-#TODO: hidden options
+is(
+	$form->hidden(undef, undef, {value => 'bar', name => 'foo', id => 'foo'}),
+	'<input id="foo" name="foo" type="hidden" value="bar">',
+	'hidden options'
+);
 
 # submit