X-Git-Url: http://git.shiar.net/perl/html-form-simple.git/blobdiff_plain/90a3c98cbb649006619309f2d5f665453018bcdd..b54221df138e749a5c2fda079ea4d6241a278a7d:/lib/HTML/Form/Simple.pm

diff --git a/lib/HTML/Form/Simple.pm b/lib/HTML/Form/Simple.pm
index 33da2b6..f96149f 100644
--- a/lib/HTML/Form/Simple.pm
+++ b/lib/HTML/Form/Simple.pm
@@ -171,7 +171,7 @@ sub select {
 
 sub radio {
 	my $self = shift;
-	my ($name, $label, $rows, $attr) = $self->_attr(3, @_);
+	my ($name, $rows, $label, $attr) = $self->_attr(3, @_);
 
 	if (not defined $rows) {
 		if (defined $label) {
@@ -213,6 +213,8 @@ sub check {
 		}
 	}
 	exists $rows->[$_]->{value} or $rows->[$_]->{value} = $_ + 1 for 0 .. $#$rows;
+	$rows->[0]->{id} = $attr->{id} || $rows->[0]->{name} || $attr->{name} || $name #XXX: //
+		if ref $label ne 'ARRAY' and defined $rows->[0] and not defined $rows->[0]->{id};
 
 	$self->select($name, $rows, {%$attr, type => 'checkbox'});
 }
@@ -237,7 +239,7 @@ HTML::Form::Simple - Generate HTML form elements
 			msg => 'Textarea default', {rows => 4, style => 'background:red'}
 		) ],
 		[ Gender => join ' or ', $input->radio(
-			sex => ['m', 'f']
+			sex => [qw(m f)], [qw(Male Female)]
 		) ],
 		[ Colour => scalar $input->select(
 			favcolour => [qw(Blue Green Red)], 'Green'
@@ -248,15 +250,50 @@ HTML::Form::Simple - Generate HTML form elements
 	);
 	say $input->stop; # </form>
 
-=head1 TODO
+=head1 DESCRIPTION
 
 =over
 
-=item C<radio>|C<check> parameter order
+=item C<hidden>
+
+	$input->hidden(name => 'value');
+
+=item C<text>
+
+	$input->text(name => 'default');
+
+=item C<select>
+
+	$input->select(name => ['option'], 'default');
+
+=item C<radio>
+
+	$input->radio(name => ['option'], ['option label'], 'default');
+
+eq
+
+	$input->radio(
+		'name',
+		[ {label => 'option label', value => 'option'} ],
+		{value => 'default'}
+	);
+
+=item C<check>
+
+	$input->check(name => ['label', 'second option'], [0, 1]);
+
+eq
 
-Row options (hash ref details) are inconsistent:
-on labels for C<check>, on values for C<radio>.
-Make behaviour more logical.
+	$input->check(name => [
+		{label => 'label',         value => 1, checked => 0},
+		{label => 'second option', value => 2, checked => 1},
+	]);
+
+=back
+
+=head1 TODO
+
+=over
 
 =item C<default()> method
 
@@ -276,6 +313,10 @@ Actual descriptions instead of just a synopsis.
 Allow custom value quotation function.
 Makes L<XML::Quote|XML::Quote> dependency optional.
 
+=item single checkbox id
+
+Do not add value to single check() by default.
+
 =back
 
 =head1 AUTHOR