XXX: reverse radio options

[perl/html-form-simple.git] / lib / HTML / Form / Simple.pm

diff --git a/lib/HTML/Form/Simple.pm b/lib/HTML/Form/Simple.pm
index 33da2b65f34854ce7e2fbc8510b7ee4dae9b5df2..59f0e4c705ef890325397f55181e5ced41f1816e 100644 (file)
--- a/lib/HTML/Form/Simple.pm
+++ b/lib/HTML/Form/Simple.pm
@@ -171,7 +171,7 @@ sub select {
 
 sub radio {
        my $self = shift;
-       my ($name, $label, $rows, $attr) = $self->_attr(3, @_);
+       my ($name, $rows, $label, $attr) = $self->_attr(3, @_);
 
        if (not defined $rows) {
                if (defined $label) {
@@ -237,7 +237,7 @@ HTML::Form::Simple - Generate HTML form elements
                        msg => 'Textarea default', {rows => 4, style => 'background:red'}
                ) ],
                [ Gender => join ' or ', $input->radio(
-                       sex => ['m', 'f']
+                       sex => [qw(m f)], [qw(Male Female)]
                ) ],
                [ Colour => scalar $input->select(
                        favcolour => [qw(Blue Green Red)], 'Green'
@@ -252,12 +252,6 @@ HTML::Form::Simple - Generate HTML form elements
 
 =over
 
-=item C<radio>|C<check> parameter order
-
-Row options (hash ref details) are inconsistent:
-on labels for C<check>, on values for C<radio>.
-Make behaviour more logical.
-
 =item C<default()> method
 
        $input->hidden(foo => $input->default('foo'));