From c4e740f0d50d526ba9c17c6ccb821aca4f1da15b Mon Sep 17 00:00:00 2001
From: Mischa POSLAWSKY <perl@shiar.org>
Date: Sat, 7 Jul 2018 21:47:58 +0200
Subject: [PATCH] login/list: prepare user data before display

Similar to login/visits; abstraction for upcoming options.
---
 login/list.php | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/login/list.php b/login/list.php
index ad2f804..4c8f4f0 100644
--- a/login/list.php
+++ b/login/list.php
@@ -4,16 +4,23 @@ if ($Args) $basepath .= '/.tags' . $Args;
 $users = glob("$basepath/*/");
 if (!$users) return;
 
+foreach ($users as $col => $userdir) {
+	$users[$col] = [
+		'dir'   => $userdir,
+		'login' => basename($userdir),
+		'name' => @file_get_contents("$userdir/name.txt"),
+	];
+}
+
 print '<ul class="gallery cat">';
 
-foreach ($users as $userdir) {
-	$user = pathinfo($userdir, PATHINFO_FILENAME);
-	$name = @file_get_contents("$userdir/name.txt") ?: ucfirst($user);
-	if (file_exists("$userdir/avatar.jpg")) {
+foreach ($users as &$user) {
+	$name = $user['name'] ?: ucfirst($user['login']);
+	if (file_exists("{$user['dir']}/avatar.jpg")) {
 		$avatar = sprintf(
 			'<img src="%s" alt="%s" />',
-			"/thumb/100/profile/$user/avatar.jpg",
-			$user
+			"/thumb/100/profile/{$user['login']}/avatar.jpg",
+			$user['login']
 		);
 		$name = sprintf(
 			'<figure>%s<figcaption>%s</figcaption></figure>',
-- 
2.30.0