From 6a6c1c31adb0932904685275f0d3d75185c0b69b Mon Sep 17 00:00:00 2001 From: Mischa POSLAWSKY Date: Tue, 17 Jul 2018 22:11:22 +0200 Subject: [PATCH] login/edit: column visibility option to restrict to admins Read-only tags become invisible, and now configurable per site. --- login/edit.inc.php | 1 + login/edit.php | 13 +++++++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/login/edit.inc.php b/login/edit.inc.php index 86b35b2..b94fa7c 100644 --- a/login/edit.inc.php +++ b/login/edit.inc.php @@ -30,6 +30,7 @@ $cols = [ 'label' => 'groepen', 'filename' => 'profile/.tags', 'values' => [], + 'visible' => 'admin', ], ]; diff --git a/login/edit.php b/login/edit.php index 49b8ed8..8f39f09 100644 --- a/login/edit.php +++ b/login/edit.php @@ -17,7 +17,15 @@ and !empty($Place['user']) and $Place['user'] !== $User['name']) { require_once('edit.inc.php'); foreach ($cols as $col => &$colconf) { - $colconf['visible'] = TRUE; + if (isset($colconf['visible'])) { + if ($colconf['visible'] == 'admin' and empty($User['admin'])) { + $colconf['visible'] = FALSE; + continue; + } + } + else { + $colconf['visible'] = TRUE; + } if (!isset($colconf['filename'])) { continue; # exceptional storage @@ -34,9 +42,6 @@ foreach ($cols as $col => &$colconf) { $target = "$tag/{$user['name']}"; $val = file_exists($target); $tags[$tagname] = ['value' => $val]; - if (empty($User['admin'])) { - continue; # forbidden - } if (!is_writable($tag)) { continue; # locked tag directory } -- 2.30.0