From: Mischa POSLAWSKY <perl@shiar.org>
Date: Wed, 15 Jan 2020 13:43:39 +0000 (+0100)
Subject: reply: ignore empty image uploads
X-Git-Tag: v4.4~20
X-Git-Url: http://git.shiar.net/minimedit.git/commitdiff_plain/ee182f5f4ab8a688284a02e534ec555e5c3093ba?ds=inline

reply: ignore empty image uploads

Fix invalid image appended for UPLOAD_ERR_NO_FILE.
---

diff --git a/widget/reply.php b/widget/reply.php
index cedcc49..7e0ec1e 100644
--- a/widget/reply.php
+++ b/widget/reply.php
@@ -10,14 +10,15 @@ if ($_POST) {
 	require_once 'upload.inc.php';
 	try {
 		$html = messagehtml($_POST['reply']);
-		if ($_FILES and isset($_FILES['image'])) {
+		if ($_FILES and !empty($_FILES['image'])) {
 			$target = 'data/upload';
 			if (!file_exists($target)) {
 				throw new Exception("er is geen uploadmap aanwezig op $target");
 			}
 			$target .= '/' . $User->login;
-			$result = userupload($_FILES['image'], $target);
-			$html .= sprintf('<p><img src="/thumb/640x/%s" /></p>', $result);
+			if ($result = userupload($_FILES['image'], $target)) {
+				$html .= sprintf('<p><img src="/thumb/640x/%s" /></p>', $result);
+			}
 		}
 		$query = $Db->set('comments', [
 			'page'    => $Page,